remove blacklist and whitelist phrases#137
Merged
DaanHoogland merged 1 commit intoapache:masterfrom Sep 18, 2020
Merged
Conversation
GabrielBrascher
approved these changes
Aug 11, 2020
DaanHoogland
added a commit
that referenced
this pull request
Sep 18, 2020
This reverts commit 13e1f5d.
yadvr
pushed a commit
that referenced
this pull request
Sep 18, 2020
Member
|
@DaanHoogland @PaulAngus you may need to re-open the PR and merge only after the upstream PR to apache/cloudstack is merged with a DB upgrade path too |
Member
Author
|
theres a closed pull for an empty DB path (apache/cloudstack#4092) do you happen to know if/what the PR for one with contents in ? (i can't find one) |
Contributor
|
I don't think I understand your question @PaulAngus . Are you asking whether any PR added DB changes to the file? |
Member
|
@PaulAngus the backend PR for this doc change hasn't been merged, so this was reverted and Daan re-opened a PR with the changes - #155 |
Member
|
The backend PR for this doc PR is - apache/cloudstack#4135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small alterations to remove the phrases blacklist and whitelist